4

I have this method:

void createSomething(Items &items)
{
    int arr[items.count]; // number of items
}

But it's throwing an error:

expression must have a constant value

I found just this solution: 

int** arr= new int*[items.count];

so I'm asking is there a better way how do handle this?

dontHaveName
  • 1,899
  • 5
  • 30
  • 54
  • 7
    Your "solution" does something quite different to what you were intending to do in the first sample. Anyway, look into `std::vector`. – juanchopanza Oct 22 '15 at 18:47
  • In case it wasn't clear to you already, you can't declare an array where the size of the array is determined at run time using the bracket notation. There are other ways of handling this (see malloc() ), but as @juanchopanza pointed out std::vector is the way to go. – Bob Oct 22 '15 at 18:52
  • 1
    I think you need to see that the correct version of you "solution" would be `int* arr = new int[items.count];` not using an array of pointers. but of course `std::vector` is better – Ryan Haining Oct 22 '15 at 18:53
  • What are you trying to do....? – Lightness Races in Orbit Oct 22 '15 at 18:55
  • I just wanted to create the array, but don't worry already got an answer. – dontHaveName Oct 22 '15 at 18:56

2 Answers2

8

You can use a std::vector

void createSomething(Items &items)
{
    std::vector<int> arr(items.count); // number of items
}

The reason your first method won't work is that the size of an array must be know at compile time (without using compiler extensions), so you have to use dynamically sized arrays. You can use new to allocate the array yourself

void createSomething(Items &items)
{
    int* arr = new int[items.count]; // number of items

    // also remember to clean up your memory
    delete[] arr;
}

But it is safer and IMHO more helpful to use a std::vector.

Cory Kramer
  • 114,268
  • 16
  • 167
  • 218
2

Built in arrays & std::array always require a constant integer to determine their size. Of course in case of dynamic arrays (the one created with new keyword) can use a non-constant integer as you have shown.

However std::vector (which of course internally a dynamic array only) uses a is the best solution when it comes to array-type applications. It's not only because it can be given a non-constant integer as size but also it can grown as well as dynamically quite effectively. Plus std::vector has many fancy functions to help you in your job.

In your question you have to simply replace int arr[items.count]; with :-

std::vector<int> arr(items.count);   // You need to mention the type
// because std::vector is a class template, hence here 'int' is mentioned

Once you start with std::vector, you would find yourself preferring it in 99% cases over normal arrays because of it's flexibility with arrays. First of all you needn't bother about deleting it. The vector will take care of it. Moreover functions like push_back, insert, emplace_back, emplace, erase, etc help you make effective insertions & deletions to it which means you don't have to write these functions manually.

For more reference refer to this

Anwesha
  • 728
  • 1
  • 7
  • 18