Android getText from EditText return NULL

Question

in this simple Application of my first program in Android i want to get username and password from User. but after click on button that return NULL and thats incorrect, username and password fields have string and are not NULL. Textusername and Textpassword in this code are NULL and can not get string from R.id.username AND R.id.password

My XML:

<?xml version="1.0" encoding="utf-8"?>
<LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
              android:orientation="vertical"
              android:layout_width="fill_parent"
              android:layout_height="fill_parent"
        >
    <LinearLayout
            android:layout_width="fill_parent"
            android:layout_height="wrap_content"
            android:orientation="horizontal"
            >

        <TextView
                android:layout_width="0dp"
                android:layout_height="40dp"
                android:layout_weight="1"
                android:text="@string/EnterUsername"
                />
        <EditText
                android:layout_width="0dp"
                android:layout_height="40dp"
                android:layout_weight="1"
                android:id="@+id/username"
                />
    </LinearLayout>
    <LinearLayout
            android:layout_width="fill_parent"
            android:layout_height="wrap_content"
            android:orientation="horizontal"
            >

        <TextView
                android:layout_width="0dp"
                android:layout_height="40dp"
                android:layout_weight="1"
                android:text="@string/EnterPassword"
                />
        <EditText
                android:layout_width="0dp"
                android:layout_height="40dp"
                android:layout_weight="1"
                android:id="@+id/password"
                />
    </LinearLayout>
    <TextView
            android:layout_width="fill_parent"
            android:layout_height="0dp"
            android:layout_weight="1"
            />
    <Button
            android:layout_width="fill_parent"
            android:layout_height="wrap_content"
            android:id="@+id/submitButton"
            android:text="@string/SubmitButton"
            android:gravity="center"
            android:background="@drawable/purple"/>
</LinearLayout>

My Code:

package com.example.AndroidMultiPage;

import android.app.Activity;
import android.content.DialogInterface;
import android.content.Intent;
import android.os.Bundle;
import android.view.View;
import android.widget.Button;
import android.widget.EditText;
import android.widget.Toast;

public class MyActivity extends Activity {
    /**
     * Called when the activity is first created.
     */
    @Override
    public void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);
        setContentView(R.layout.main);

        final EditText username = (EditText) findViewById(R.id.username);
        final EditText password = (EditText) findViewById(R.id.password);

        Button   submit   = (Button)   findViewById(R.id.submitButton);

        final String Textusername = username.getText().toString();
        final String Textpassword = password.getText().toString();

        submit.setOnClickListener(new View.OnClickListener() {
            @Override
            public void onClick(View view) {
                Toast.makeText(
                         MyActivity.this, Textusername, 
                         Toast.LENGTH_SHORT).show();

                //TOAST SHOW NULL
            }
        });
    }
}

score 2 · Answer 1 · answered Jul 23 '14 at 07:06

You should move

 final String Textusername = username.getText().toString();
 final String Textpassword = password.getText().toString();

under onClick(..) of submit Button and inside onClick(..) you should check String values are NULL or not. as @Raghunandan said...

score 1 · Answer 2 · answered Jul 23 '14 at 07:07

1

Move this

String Textusername = username.getText().toString();
String Textpassword = password.getText().toString();

inside onClick.

ALso check

if(!TextUtils.isEmpty(Textusername))
{
           // display Toast 
}

answered Jul 23 '14 at 07:07

Raghunandan

132,755
26
225
256

score 1 · Answer 3 · edited Jul 28 '15 at 19:14

1

Try below code:

submit.setOnClickListener(new View.OnClickListener() {
    @Override
    public void onClick(View view) {
        final String Textusername = username.getText().toString();
        final String Textpassword = password.getText().toString();

        Toast.makeText(MyActivity.this, Textusername, Toast.LENGTH_SHORT).show();    
    }
});

edited Jul 28 '15 at 19:14

mbm29414

11,558
6
56
87

answered Jul 23 '14 at 07:09

Pratik Dasa

7,439
4
30
44

score 1 · Accepted Answer · answered Jul 23 '14 at 07:24

1

Please move this

final String Textusername = username.getText().toString(); final String Textpassword = password.getText().toString();

inside onClick().

answered Jul 23 '14 at 07:24

Aniruddha

4,477
2
21
39

thanks. after that i get this error `Unfortundately SimpleIntent has Stoped` – DolDurma Jul 23 '14 at 07:30
Then please post the logcat. – Aniruddha Jul 23 '14 at 07:34

score 1 · Answer 5 · edited Jul 24 '14 at 05:38

1

submit.setOnClickListener(new OnClickListener() {


     @Override
                public void onClick(View view) {

                   String Textusername = username.getText().toString();

                    Toast.makeText(MyActivity.this, Textusername, Toast.LENGTH_SHORT).show();

                    //TOAST SHOW NULL
                }
            });

edited Jul 24 '14 at 05:38

DolDurma

15,753
51
198
377

answered Jul 23 '14 at 11:40

Android Man

319
2
6
22

score 0 · Answer 6 · answered Jul 23 '14 at 07:35

Use this:
 submit.setOnClickListener(new View.OnClickListener() {
            @Override
            public void onClick(View view) {
String text_user=username.getText().toString();
                Toast.makeText(
                         MyActivity.this, text_user, 
                         Toast.LENGTH_SHORT).show();

                            }
        });

Android getText from EditText return NULL

6 Answers6

Linked