C# Nested Classes and Inheritance

Question

Just need some help with nested classes and inheritance..

namespace blah
{
    private abstract class InheritedSomething
    {
        public void doSomething() {};
    }

    class OtherClass : InheritedSomething
    {
        //Stuff

        class NestedClass : InheritedSomething
        {
            //Stuff
        }
    }
}

Is this the correct way of doing things? It seems a bit redundant that NestedClass inherits InerhitedSomething when its parent class already inherits this... But when I remove the inheritance from NestedClass it asks me to make doSomething() a static method.

So my question is, which way is "correct" - Both OtherClass and NestedClass inheriting InheritedSomething or only OtherClass inherits InheritedSomething and doSomething() becomes public static void?

Thanks!

Should doSomething have the same implementation in both classes? Or does doSomething differ in OtherClass vs NestedClass? — Steven Wexler, May 10 '13 at 04:53

score 0 · Answer 1 · edited May 23 '17 at 10:25

0

There's nothing wrong with this design.

The suggestion that a method can be made static is a completelly separate issue. Note, that can doesn't mean it should. (Read more about deciding here or here). When you remove the inheritance, doSomething isn't overriding anymore which makes it eligible to be checked for this suggestion.

edited May 23 '17 at 10:25

Community

1
1

answered May 10 '13 at 09:13

lisp

4,138
2
26
43

score 0 · Answer 2 · answered May 12 '13 at 23:39

0

Correct or not depends on what you intend to do.

Inner types have privileged access to enclosing type members but do not derive from it.

What is your intention with these classes?

answered May 12 '13 at 23:39

Paulo Morgado

14,111
3
31
59

C# Nested Classes and Inheritance

2 Answers2