1

The regular expression ^((\(\d{3}\) ?)|(\d{3}-))?\d{3}-\d{4}$ matches strings of the form XXX-XXX-XXXX and XXX-XXXX (am I missing out something?).

It doesn't, however, match (XXX) XXX-XXXX and (XXX) XXX-XXX-XXXX as well (which I need it to match).

Can you help me fix it so that it matches the formats
     XXX-XXX-XXXX, XXX-XXXX, (XXX) XXX-XXXX, (XXX) XXX-XXXX
without causing it to match other string formats which I don't want?

Gilles 'SO- stop being evil'
  • 104,111
  • 38
  • 209
  • 254
user181218
  • 1,655
  • 5
  • 28
  • 42

5 Answers5

6

Your specification is a bit confusing. Your last two cases appear the same:
XXX-XXX-XXXX
XXX-XXXX
(XXX) XXX-XXXX
(XXX) XXX-XXXX

(It looks like you're trying to match a phone number, is that right?) Assuming your last case is "(XXX)XXX-XXXX" (no space between area code and regular number, which I assume is the " ?" meaning optional space) then your RegExp is almost correct, just add two backslashes in front of the area code parentheses so they're matched as plain characters and not special grouping characters:

^((\(\d{3}\) ?)|(\d{3}-))?\d{3}-\d{4}$

Note that your regular expression may not have come through correctly, I noticed that stack overflow removed a single backslash from the RE pattern, I had to type a double backslash "\\" in order to get a single backslash to come out in the message

Bogatyr
  • 19,255
  • 7
  • 59
  • 72
2

Try this:

(\(\d{3}\) )?(\d{3}-){1,2}(\d{4})
Rubens Farias
  • 57,174
  • 8
  • 131
  • 162
0

You need to escape the parenthesis, like this: \( otherwise, they do not get matched and do captures instead.

Palantir
  • 23,820
  • 10
  • 76
  • 86
0

^(((\d{3}) ?)|(\d{3}-))?\d{3}-\d{4}$^

this will work.

Priyanka Acharya
  • 131
  • 1
  • 4
-1

I think so this is what you are looking for,

/^((((([0-9]{3})-)|((([0-9]{3}))\s))([0-9]{3})-([0-9]{4}))|(([0-9]{3})-([0-9]{4})))$/

It will work for below patterns XXX-XXX-XXXX, XXX-XXXX, (XXX) XXX-XXXX

santosh kore
  • 976
  • 1
  • 12
  • 21