Toggling disabled attribute

Question

I am looking for a way to clean/condense/improve the performance of my current snippet: input & output are already defined variables.

if (input.val().length <= 0) {
    output.attr('disabled', true);
} else {
    output.attr('disabled', false);
}

score 3 · Accepted Answer · answered Mar 24 '13 at 10:24

3

Well, you can use the boolean expression directly:

output.attr('disabled', input.val().length <= 0);

answered Mar 24 '13 at 10:24

T.J. Crowder

score 1 · Answer 2 · answered Mar 24 '13 at 10:26

1

You should be using prop over attr. See here http://api.jquery.com/prop/

output.prop('disabled', (input.val().length <= 0));

answered Mar 24 '13 at 10:26

whitneyit

It doesn't matter, the jQuery team *immediately* backed off making `attr` only work on attributes as soon as 1.6 came out. (And of course, `disabled` **is** an attribute, through if we were being very strict, we wouldn't use `true` and `false` with it.) `attr` works just fine for `disabled` and that's not likely to change. – T.J. Crowder Mar 24 '13 at 10:37

score 0 · Answer 3 · answered Mar 24 '13 at 10:25

0

output.attr('disabled', (input.val().length <= 0));

answered Mar 24 '13 at 10:25

Manish Mishra

3 Answers3